Question on Bubble sort.

[Dan R.]

assigment was to read a file of ints and sort it thats no problem. Extra credit is to read in names from a file and sort them.. Having problems making this sort strings instead of ints.. when i used strcpy and strcmp i could not get it to work.


void bubbleSort1(int x[], int n) {
for (int pass=1; pass < n; pass++) {

for (int i=0; i < n-pass; i++) {
if (x[i] > x[i+1]) {
// exchange elements
int temp = x[i]; x[i] = x[i+1]; x[i+1] = temp;
}
}
}
}

[omnius]

You need to post the code you've been trying to use for strings for us to be able to offer concrete advice. The actual solution will depend on whether you're using C-style strings or C++ std::string class. It's not obvious to me from the code you posted whether you're coding in C or C++.

If you use the std::string class you can compare directly using < and > operators.

If using strcmp() with C-style strings (as seems likely) check the return value to see if it is less than or greater than zero.

if(strcmp(str1,str2) < 0) {
// str1 is lexographically less than str2


if(strcmp(str1,str2) > 0) {
// str1 is lexographically greater than str2

[mfrank410]

If your sorting strings you dont want to be using strcmp(). All that function does is compare to see if two strings are equal.

You want to sort, by characters.

Sort all strings by first character.
Sort all strings by second character.
etc.
The one catch is you have to ignore the strings that are, say 3 characters in length when you are sorting the strings that are 5 characters in length.

cat
dog
mouse
bird

b
c
d
m

bi
ca
do
mo

bir
cat
dog
mou

bird
cat <-ignore
dog <-ignore
mous

bird <-ignore
cat <-ignore
dog <-ignore
mouse

If you still need some help I can post some sample code to do it.

good luck

[RecursiveS]

If your sorting strings you dont want to be using strcmp(). All that function does is compare to see if two strings are equal.

or less than, or greater than.......

Return Value

The return value for each of these functions indicates the lexicographic relation of string1 to string2.

Value Relationship of string1 to string2

< 0 string1 less than string2
0 string1 identical to string2
> 0 string1 greater than string2

[omnius]

If your sorting strings you dont want to be using strcmp(). All that function does is compare to see if two strings are equal.
...
...
If you still need some help I can post some sample code to do it.

Please look up the strcmp() function in your reference book before you start posting sample code. Thanks.

[mfrank410]

My bad...sorry your right.

Anyways, I just never use strcmp() to test strings especially sorting. I find you can write much quicker code by actually writing your own character by character sort algorithm.

But to his, his own

[RecursiveS]

My bad...sorry your right.

Anyways, I just never use strcmp() to test strings especially sorting. I find you can write much quicker code by actually writing your own character by character sort algorithm.

omnius is just gonna love this......



And so I stray, like an innocent lamb into the slaughterhouse......

How does that work mfrank410

[RecursiveS]

Not that I'm doubting you, just interested.