Beginners Task #2

[merlinfire]

I never really got any useful comments except splitting hairs


TEACH ME! IT'S YOUR JOB!

Wait.....

[Guest]

I never really got any useful comments except splitting hairs


TEACH ME! IT'S YOUR JOB!

Wait.....

I do not get it?

[merlinfire]

I never really got any useful comments except splitting hairs


TEACH ME! IT'S YOUR JOB!

Wait.....

I do not get it?

I meant comments about my solution to this problem.

[Guest]

I meant comments about my solution to this problem.

oh, no one really got any comments.

I did tested your code and if I put in a letter it loops forever and if 1 is entered the same. Not sure why but it also does not seem to end it just sits like is doing some thing but is not and it is not the system pause and I am not a fan of system pause.

[Guest]

I meant comments about my solution to this problem.

Code: Select all

  if ((y==x-1 || y==x) && prime !=1)
     {   
         cout << " " << x << endl;
         prime=1;
         // <-- missing statement here.
          }   

You forgot a statement in this block.

[merlinfire]

what did I miss? what should be there?

[merlinfire]

Oh, I see what I missed. Except for the non-number inputs, I added another control structure with no way to break out in the code -->
while (factorfest==0) . That has been fixed. I'm not sure how to check whether the input is a number or not...

Code: Select all

#include <iostream>
#include <stdlib.h>
using namespace std;
int main()
{
    int oneleft=0;
    int x=0;
    int y=0;
    cout << "Factorial Prog 1.01." << endl;
    cout << "Enter your number to be decomposed for factors." << endl;
    cin >> x;
    cout << endl;
    int prime=0;
    int factorfest=0;
    while (prime==0)
       {       
        factorfest=0;
        y=1;
   while (factorfest==0)
        {     
         
       
        if (x==0 || x==1)
      {
      cout << "Your number is a " << x <<".  It cannot be factored.  What a ch00b."<< endl;
      prime =1;
      factorfest=1;
      }
 
       y++;
     if (x%y==0 && prime!=1)
     {
         cout << y <<" x ";
          x=x/y;
           factorfest=1;
}   
         
  if ((y==x-1 || y==x) && prime !=1)
     {   
         cout << " " << x << endl;
         prime=1;
          factorfest=1;
          }   
          }   
          } 
system("PAUSE");
  return 0;
}

[tomcant]

I'm not sure how to check whether the input is a number or not...

isdigit(num);

[merlinfire]

I'm not sure how to check whether the input is a number or not...

isdigit(num);

Thanks! Is there a particular library I must include for that function?

[Guest]

Oh, I see what I missed. Except for the non-number inputs, I added another control structure with no way to break out in the code -->
while (factorfest==0) . That has been fixed. I'm not sure how to check whether the input is a number or not...

You are welcome.

[tomcant]

I'm not sure how to check whether the input is a number or not...

isdigit(num);

Thanks! Is there a particular library I must include for that function?

#include <cctype>

[Guest]

tomcant did you post your solution in another thread because I can not seem to find yours?

[tomcant]

I think, since I'm the host, I am not supposed to? But if you wanna see my version, sure...

Code: Select all

#include <iostream>

using namespace std;

int main()
{
   cout << "Enter a number to factor: ";
   
   int first = 2, val;
   cin >> val;   
   
   cout << "Prime factors = ";
   for(; val >= first*first; ++first)
   {
      for(; val % first == 0;)
      {
         cout << first;
         if(val > first) cout << " x ";
         val /= first;         
      }      
   }

   if(val > 1) cout << val;

   cin.ignore();
   cin.get();
   return(0);
}

Please comment

[tomcant]

w00ps.. forgot to add support for numbers lower than 4.... here we go:

Code: Select all

#include <iostream>

using namespace std;

int main()
{
   cout << "Enter a number to factor: ";
   
   int first = 2, val;
   cin >> val;   
   
   if(val <= 3)
   {
      cout << "Prime factors = " << val << endl;
      cin.ignore();
      cin.get();
      return(0);
   }
   
   cout << "Prime factors = ";
   for(; val >= first*first; ++first)
   {
      for(; val % first == 0;)
      {
         cout << first;
         if(val > first) cout << " x ";
         val /= first;         
      }      
   }

   if(val > 1) cout << val;

   cin.ignore();
   cin.get();
   return(0);
}

[Guest]

I think, since I'm the host, I am not supposed to? But if you wanna see my version, sure...

Please comment

Oh, I thought that is what happened. I am sure it is alright as Johnny T posted his solution.

Very Nice solution.

If you care I did enter a letter in you solution and got this:
Enter a number to factor: k
Prime factors = -858993460